Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Delete unused PrebuildQueueMaintainer and PrebuildRateLimiter #5835

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Sep 23, 2021

As discussed in our call today @AlexTugarev 🙂

Description

The PrebuildQueueMaintainer and PrebuildRateLimiter classes are currently dead code, and wouldn't work as is today anyway.

Related Issue(s)

How to test

Release Notes

NONE

/uncc

@AlexTugarev
Copy link
Member

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 09f1158f60d633adc671b36d9dec6417d73e4712

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: AlexTugarev

No associated issue. Requirement bypassed by manually added approval.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit bb6f2fd into main Sep 24, 2021
@roboquat roboquat deleted the jx/delete-prebuild-queue branch September 24, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants